Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eth): add EthSendRawTransactionUntrusted, use via gateway eth_sendRawTransaction #12431

Merged
merged 3 commits into from
Sep 7, 2024
Merged

feat(eth): add EthSendRawTransactionUntrusted, use via gateway eth_sendRawTransaction #12431

merged 3 commits into from
Sep 7, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Sep 4, 2024

Also improves the test coverage for MpoolPush* variants.

@rvagg rvagg requested review from masih and Stebalien September 4, 2024 04:38
@rvagg rvagg self-assigned this Sep 4, 2024
@rvagg rvagg requested a review from ZenGround0 September 4, 2024 04:38
@Stebalien
Copy link
Member

panic: reflect.Set: value of type *api.Gateway is not assignable to type full.EthModuleAPI

Base automatically changed from rvagg/require.Eventually to master September 4, 2024 20:15
@Stebalien Stebalien force-pushed the rvagg/EthSendRawTransactionUntrusted branch from c608063 to 2b11b0e Compare September 4, 2024 22:09
@rvagg rvagg force-pushed the rvagg/EthSendRawTransactionUntrusted branch from 2b11b0e to f56b61d Compare September 5, 2024 05:35
@rvagg
Copy link
Member Author

rvagg commented Sep 5, 2024

Yeah, ok, much more complicated if we don't want to expose this on the GatewayAPI. So instead I've moved this new one from EthModuleAPI to EthAPI, but then it entangles us with some other dependencies so I had to reorg some other pieces to get it to all wire up properly. But this should be good now.

@rvagg rvagg force-pushed the rvagg/EthSendRawTransactionUntrusted branch from f56b61d to 232daaf Compare September 5, 2024 06:12
Stebalien
Stebalien approved these changes Sep 6, 2024
View reviewed changes
node/impl/full/eth.go Outdated Show resolved Hide resolved
@rvagg rvagg force-pushed the rvagg/EthSendRawTransactionUntrusted branch from 232daaf to 8035e02 Compare September 7, 2024 08:07
@rvagg rvagg requested a review from Stebalien September 7, 2024 08:08
@rvagg rvagg enabled auto-merge (squash) September 7, 2024 08:09
@rvagg rvagg merged commit 42e6e41 into master Sep 7, 2024
83 checks passed
@rvagg rvagg deleted the rvagg/EthSendRawTransactionUntrusted branch September 7, 2024 08:14
@simlecode simlecode mentioned this pull request Sep 18, 2024
Closed
44 tasks
@rvagg rvagg mentioned this pull request Oct 3, 2024
Open
@rvagg rvagg mentioned this pull request Dec 18, 2024
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masih masih Awaiting requested review from masih

@ZenGround0 ZenGround0 Awaiting requested review from ZenGround0

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees

@rvagg rvagg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvagg @Stebalien