Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): trim and compress genesis CARs in build #12439

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Sep 10, 2024

Ref: filecoin-project/lotus-infra#1627
Ref: filecoin-project/lotus-infra#1628

  • Remove WASM actors from butterflynet.car
  • Compress with zstd

Resulting lotus binary is 10.7MiB smaller, 251M -> 241M.

Draft for now because it needs to be confirmed working.

@rvagg rvagg requested review from masih and rjan90 September 10, 2024 00:52
@rvagg
Copy link
Member Author

rvagg commented Sep 10, 2024

/cc @ribasushi

Copy link
Collaborator

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

Unable to confirm it works because https://github.com/filecoin-project/lotus/blob/a83d02efbaf/build/bootstrap/butterflynet.pi is no longer live

But don't see why it wouldn't work.

@rjan90
Copy link
Contributor

rjan90 commented Sep 10, 2024

Can confirm I was able to join a newly reset butterfly-network with a stripped out and compressed genesis CAR-file which was added as a Butterfly-asset in: #12443.

Screenshot 2024-09-10 at 11 35 30

@rvagg rvagg marked this pull request as ready for review September 10, 2024 10:12
@rvagg
Copy link
Member Author

rvagg commented Sep 10, 2024

Cool, let's combine and merge then, although we probably want a changelog entry. Would you mind doing that in your PR @rjan90? I'm off for the night.

* chore: add reset butterfly assets

chore: add reset butterfly assets

* chore: correct placement of genesis

chore: correct placement of genesis

* chore: strip and compress butterfly genesis car-file

chore: strip and compress butterfly genesis car-file

* chore: remove unstripped butterfly car

chore: remove unstripped butterfly car

* chrore: add changelog entry

chrore: add changelog entry
@rvagg rvagg merged commit 6c63df6 into master Sep 11, 2024
83 checks passed
@rvagg rvagg deleted the rvagg/genesis-compress branch September 11, 2024 23:00
@rjan90 rjan90 mentioned this pull request Sep 12, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

4 participants