Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(f3): f3 integration tests #12486

Merged
merged 11 commits into from
Sep 20, 2024
Merged

test(f3): f3 integration tests #12486

merged 11 commits into from
Sep 20, 2024

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Sep 18, 2024

Related Issues

Replaces #12204

Proposed Changes

Add integration tests for F3. This also changes the pubsub configuration logic such that the tests can be configured without changing global build variables.

Checklist

Before you mark the PR ready for review, please make sure that:

@Stebalien Stebalien added the skip/changelog This change does not require CHANGELOG.md update label Sep 18, 2024
@Stebalien Stebalien force-pushed the f3-itests branch 3 times, most recently from 3f1c836 to 13a8044 Compare September 18, 2024 15:13
Co-authored-by: Alfonso de la Rocha <adlrocha@tutamail.com>
Co-authored-by: Jakub Sztandera <oss@kubuxu.com>
@Stebalien Stebalien force-pushed the f3-itests branch 2 times, most recently from 087f2d3 to 27b5a43 Compare September 18, 2024 19:10
@Stebalien Stebalien marked this pull request as ready for review September 18, 2024 19:13
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kubuxu Kubuxu self-requested a review September 18, 2024 20:43
chain/lf3/manifest.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one comment, LGTM.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stebalien Stebalien changed the title test(f3): F3 Integration Tests test(f3): f3 integration tests Sep 20, 2024
@github-actions github-actions bot dismissed their stale review September 20, 2024 13:38

PR title now matches the required format.

@Stebalien Stebalien enabled auto-merge (squash) September 20, 2024 13:39
@Stebalien Stebalien disabled auto-merge September 20, 2024 13:45
@Stebalien Stebalien merged commit a30d024 into master Sep 20, 2024
83 checks passed
@Stebalien Stebalien deleted the f3-itests branch September 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: Done
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants