fix(f3): try again when we fail to fetch the manifest #12634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
added
the
skip/changelog
rvagg
approved these changes
Oct 24, 2024
Stebalien
force-pushed
the
steb/fix-f3-participate-panic
branch
from
b6d5237
to
384f136
Compare
|
We should have more tests, but there's now a test for this specific issue. |
Stebalien
added a commit
to Stebalien/curio
that referenced
this pull request
Oct 24, 2024
If we keep going here, we'll panic. See (also includes a regression test): filecoin-project/lotus#12634
Continuing with the function here will lead to a panic. This can happen, e.g., if the lotus node stops and/or returns an error while the participant is waiting for its lease to expire.
Stebalien
force-pushed
the
steb/fix-f3-participate-panic
branch
from
384f136
to
f5e827f
Compare
|
cc @rjan90 this should be backported (requires miner release). |
|
Curio PR here: filecoin-project/curio#298 |
rvagg
approved these changes
Oct 24, 2024
rjan90
pushed a commit
that referenced
this pull request
Oct 24, 2024
Continuing with the function here will lead to a panic. This can happen, e.g., if the lotus node stops and/or returns an error while the participant is waiting for its lease to expire.
21 tasks
magik6k
pushed a commit
to filecoin-project/curio
that referenced
this pull request
Oct 24, 2024
If we keep going here, we'll panic. See (also includes a regression test): filecoin-project/lotus#12634
rjan90
pushed a commit
that referenced
this pull request
Oct 28, 2024
Continuing with the function here will lead to a panic. This can happen, e.g., if the lotus node stops and/or returns an error while the participant is waiting for its lease to expire.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Try again when we fail to fetch the manifest (reported via Antithesis). Continuing with the function here will lead to a panic. This can happen, e.g., if the lotus node stops and/or returns an error while the participant is waiting for its lease to expire.
Checklist
Before you mark the PR ready for review, please make sure that: