fix(f3): poll the lease by repeatedly participating instead of checking progress #12640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng progress Previously, the flow was: 1. Get ticket. 2. Participate. 3. Repeatedly poll progress. The new flow is: 1. Get ticket. 2. Repeatedly participate, using the returned lease as an indicator of progress. That way, if the lotus node reboots we'll eventually re-tell them about the lease. fixes filecoin-project/go-f3#719
Stebalien
commented
Oct 25, 2024
masih
approved these changes
Oct 25, 2024
|
The failed test is from #12618 and looks like either a test bug or a real bug, but it's not related to this PR. |
rjan90
pushed a commit
that referenced
this pull request
Oct 28, 2024
…ng progress (#12640) Previously, the flow was: 1. Get ticket. 2. Participate. 3. Repeatedly poll progress. The new flow is: 1. Get ticket. 2. Repeatedly participate, using the returned lease as an indicator of progress. That way, if the lotus node reboots we'll eventually re-tell them about the lease. fixes filecoin-project/go-f3#719
21 tasks
rjan90
pushed a commit
that referenced
this pull request
Oct 28, 2024
…ng progress (#12640) Previously, the flow was: 1. Get ticket. 2. Participate. 3. Repeatedly poll progress. The new flow is: 1. Get ticket. 2. Repeatedly participate, using the returned lease as an indicator of progress. That way, if the lotus node reboots we'll eventually re-tell them about the lease. fixes filecoin-project/go-f3#719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
filecoin-project/go-f3#719
Proposed Changes
Previously, the flow was:
The new flow is:
That way, if the lotus node reboots we'll eventually re-tell them about the lease.
Additional Info
I think this works, but I still need to go through it again and do more testing. I also really want to simplify our error handling a bit here.
We'll also be able to simplify this even more once we can get rid of the dynamic manifest stuff.
Checklist
Before you mark the PR ready for review, please make sure that: