Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(chain): test forking before/after finality #12652

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Oct 28, 2024

Related Issues

tests for #12650

Proposed Changes

Test checkpoints beyond finality. Specifically, ensure:

  1. We can checkpoint before finality.
  2. We cannot fork more than finality epochs.

Additional Info

I had to add a bit of a hack to the chain-gen logic to optionally prevent time (state) from moving forwards. Otherwise, we'd lose all power and actually providing window posts was going to be too much trouble.

Checklist

Before you mark the PR ready for review, please make sure that:

@Stebalien Stebalien added the skip/changelog This change does not require CHANGELOG.md update label Oct 28, 2024
chain/gen/gen.go Show resolved Hide resolved
chain/gen/gen.go Show resolved Hide resolved
Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Stebalien Stebalien merged commit 2b7f595 into master Oct 28, 2024
86 of 87 checks passed
@Stebalien Stebalien deleted the steb/test-checkpoint branch October 28, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants