fix(api): make stick sessions actually work and make them non-racy #12665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/fix-sticky-race
branch
from
053d0aa to
c284b42
Compare
8 tasks
We apparently have a way to specify that all "related" requests should go to the same node. However: 1. It didn't work at all. All future requests would go to the first successful node from the first request. Because that's how stack variables work. 2. It was racy if the context was re-used concurrently. But only the first time, see point 1.
Stebalien
force-pushed
the
steb/fix-sticky-race
branch
from
c284b42 to
7640282
Compare
1. Test whether or not it works. 2. Test stickiness.
Stebalien
force-pushed
the
steb/fix-sticky-race
branch
from
7640282 to
1e721d8
Compare
magik6k
reviewed
Nov 1, 2024
magik6k
approved these changes
Nov 1, 2024
This was referenced Nov 1, 2024
rjan90
pushed a commit
that referenced
this pull request
Nov 4, 2024
…12665) * fix(api): make stick sessions actually work and make them non-racy We apparently have a way to specify that all "related" requests should go to the same node. However: 1. It didn't work at all. All future requests would go to the first successful node from the first request. Because that's how stack variables work. 2. It was racy if the context was re-used concurrently. But only the first time, see point 1. * test(api): test the API merge proxy 1. Test whether or not it works. 2. Test stickiness. * fix(api): update OnSingleNode documentation
rjan90
pushed a commit
that referenced
this pull request
Nov 6, 2024
…12665) * fix(api): make stick sessions actually work and make them non-racy We apparently have a way to specify that all "related" requests should go to the same node. However: 1. It didn't work at all. All future requests would go to the first successful node from the first request. Because that's how stack variables work. 2. It was racy if the context was re-used concurrently. But only the first time, see point 1. * test(api): test the API merge proxy 1. Test whether or not it works. 2. Test stickiness. * fix(api): update OnSingleNode documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
We apparently have a way to specify that all "related" requests should go to the same node. However:
Proposed Changes
Use an atomic, get rid of a few of the odd decisions, and write a test.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: