Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DealID to DealInfo #1392

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Add DealID to DealInfo #1392

merged 1 commit into from
Mar 11, 2020

Conversation

jsign
Copy link
Contributor

@jsign jsign commented Mar 11, 2020

This enables, from a proposalCid having the dealID, which is useful for calling:
StateMarketStorageDeal(context.Context, uint64, types.TipSetKey) (*actors.OnChainDeal, error)

@jsign
add dealID in DealInfo
07df6e0 
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
whyrusleeping
whyrusleeping approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic

@whyrusleeping whyrusleeping merged commit d4c0dfa into filecoin-project:master Mar 11, 2020
@jsign jsign mentioned this pull request Mar 18, 2020
Closed
@jsign jsign mentioned this pull request Mar 25, 2020
Merged
@andrewxhill andrewxhill mentioned this pull request Mar 4, 2021
Closed
@carsonfarmer carsonfarmer mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsign @whyrusleeping