Re: #1267: Deduct gas cost for reverted txs #1410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another option might be to create snapshot after gas is transferred to |
|
Yeah, I think @Kubuxu is right here. We should do the snapshotting after the gas withdrawal. Nonces also should be incremented after message failures, is that not happening right now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current setup, when a msg fails and needs to be reverted, the deduction of gas cost also gets reverted. This PR fixes this by directly deducting gas costs from the sender when a msg is reverted.
This test demonstrates the bug being fixed: filecoin-project/chain-validation@590c14b