New validation package #1494
Closed
New validation package #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanzafame
reviewed
Apr 2, 2020
schomatis
force-pushed
the
feat/add-validation-package
branch
3 times, most recently
from
161ce6b
to
be61d7d
Compare
schomatis
commented
Apr 13, 2020
Comment on lines
+447
to
+449
| if errorWithCategory, ok := err.(validation.ErrorWithCategory); ok { | ||
| return errorWithCategory.Category() != validation.BlockFutureTimestamp | ||
| } |
schomatis
commented
Apr 13, 2020
Comment on lines
-523
to
+533
| now := uint64(time.Now().Unix()) | ||
| if h.Timestamp > now+build.AllowableClockDrift { | ||
| return xerrors.Errorf("block was from the future (now=%d, blk=%d): %w", now, h.Timestamp, ErrTemporal) | ||
| maxTimeDrift := time.Now().Add(build.AllowableClockDrift) | ||
| if h.Timestamp > uint64(maxTimeDrift.Unix()) { | ||
| return validation.BlockFutureTimestamp.FromString(fmt.Sprintf("%s > %s", time.Unix(int64(h.Timestamp), 0).Format("%FT%T"), maxTimeDrift.Format("%FT%T"))) | ||
| // FIXME: There surely is a simpler way to format these times. |
|
There are still more validations that need to be extracted but this branch moves too fast so I rather get this reviewed and merged now and continue the extraction in a follow-up PR. |
schomatis
force-pushed
the
feat/add-validation-package
branch
from
be61d7d
to
931a384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might need a broader name later, naming it "security" seemed too much.
Encapsulate and extract validation errors (e.g., block, messages) for explicit testing later. One of the objectives is to distinguish between validation errors (e.g., invalid signature) exposed to the consumer and with potential security implications from internal errors (e.g., network timeout). This also allows us to have a central place to control validation checks.
This package should also extract validation logic as well as just errors, starting with the latter simplifies this PR to get something going. The downside is that this incorrect separation boundary causes many ugly
validation.*imports. Ideally in the future all the validation code should be concentrated and encapsulated to minimize cross-over.