Add skeleton of a config #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took way longer than it should had because I was researching exisiting options. As it turns out, nothing nice exists that would handle: - Multiple overridiable config files - Defaults provided in a struct - Output in a struct License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
|
@magik6k how would you wire in config.Root to api server? |
|
We shouldn't mix config into the DI stuff, there was a discussion on this in go-ipfs and we decided that it should be kept separate (mixing those makes life harder, especially when reading the code). I'll handle this |
magik6k
force-pushed
the
feat/config
branch
3 times, most recently
from
e7e46b3
to
700cb18
Compare
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
whyrusleeping
approved these changes
Jul 5, 2019
Kubuxu
pushed a commit
that referenced
this pull request
Apr 6, 2020
# This is the 1st commit message: WIP: random beacon interface Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai> # The commit message #2 will be skipped: # add code i forgot to add # # Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
magik6k
pushed a commit
that referenced
this pull request
Jun 24, 2020
magik6k
pushed a commit
that referenced
this pull request
Aug 10, 2020
ticket-acquiring function takes tipset identifier
kikakkz
added a commit
to EntropyPool/lotus
that referenced
this pull request
Apr 12, 2021
…on-entropypool-8.19.1 Ntwk calibration entropypool 8.19.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took way longer than it should have because I was researching existing
options.
As it turns out, nothing nice exists that would handle:
This settles for much less, just TOML and no overrides apart from default.