Implement PoSt scheduler #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Sep 18, 2019
| return ts, nil | ||
| } | ||
|
|
||
| pts, err := cs.LoadTipSet(ts.Parents()) |
There was a problem hiding this comment.
Optimization: we could use chain/events.tipSetCache here, but that can be done later
Make events subsystem work on top of API
Merged
Kubuxu
reviewed
Sep 19, 2019
whyrusleeping
commented
Sep 19, 2019
whyrusleeping
commented
Sep 19, 2019
Kubuxu
reviewed
Sep 19, 2019
|
I'm not seeing the out of bounds panic you pointed out, but I do see this: |
refactor to use 'randomness' as input to new vm creation
Kubuxu
reviewed
Sep 20, 2019
| log.Warnf("not restarting listenHeadChanges: context error: %s", ctx.Err()) | ||
| return | ||
| } | ||
| time.Sleep(time.Second) |
There was a problem hiding this comment.
This only happens when there is a critical error in the event handling loop, which in most cases would be API connection timing out / disconnecting, and this sleep prevents unnecessarily spamming the logs
Kubuxu
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a bit of a WIP, and won't be done done until the actor methods are implemented.
However, I think theres room for some review already.