Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update markets to resolve dialing errors #2851

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Update markets to resolve dialing errors #2851

merged 2 commits into from
Aug 5, 2020

Conversation

hannahhoward
Copy link
Contributor

@hannahhoward hannahhoward commented Aug 5, 2020 •
edited
Loading

Goals

Resolve dialing errors via filecoin-project/go-fil-markets#356

Implementation

  • Implement GetKnownAddresses on RetrievalClientNode adapter
  • Convert to passing around the full retrieval peer in the API structs
  • Sorry @arajasek it ended up not making sense to have a RetrievalProviderInfo given we already have a RetrievalPeer and it just started to get confusing with too many structs

@magik6k magik6k merged commit e01df1c into next Aug 5, 2020
@magik6k magik6k deleted the feat/update-markets-0.5.4 branch August 5, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@arajasek arajasek Awaiting requested review from arajasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahhoward @magik6k