Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load fewer messages from disk when serving blocksync requests #3494

Merged
merged 2 commits into from
Sep 2, 2020
Merged

load fewer messages from disk when serving blocksync requests #3494

merged 2 commits into from
Sep 2, 2020

Conversation

whyrusleeping
Copy link
Member

No description provided.

@schomatis
Copy link
Contributor

Not sure what's the test error.

schomatis
schomatis suggested changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TestSyncSimple is stalled (tested locally). I can review this in detail later today if you can't fix.

magik6k
magik6k reviewed Sep 2, 2020
View reviewed changes
chain/blocksync/server.go Outdated Show resolved Hide resolved
@schomatis @magik6k
Update chain/blocksync/server.go
ca8f586 
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
schomatis
schomatis approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we're talking, thanks @magik6k.

@magik6k magik6k merged commit d552803 into master Sep 2, 2020
@magik6k magik6k deleted the feat/faster-blocksync-serving branch September 2, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@vyzo vyzo vyzo approved these changes

@schomatis schomatis schomatis approved these changes

@arajasek arajasek Awaiting requested review from arajasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whyrusleeping @schomatis @vyzo @magik6k