Stop SyncIncomingBlocks from leaking into chainwatch processing; No panics during processing #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
reviewed
Sep 3, 2020
placer14
force-pushed
the
fix/chainwatch/no-panic-during-processing
branch
from
e677bce
to
798f4d7
Compare
The SQL query was anchoring data from the `blocks` table, which includes all blocks seen from SyncIncomingBlocks which isn't always available in the chainstate via the API. In order to prevent these blocks from leaking into normal processing (which errors anyway), the join was changed to allow `blocks_synced` to anchor the set as we originally intended.
placer14
force-pushed
the
fix/chainwatch/no-panic-during-processing
branch
from
798f4d7
to
abaef98
Compare
magik6k
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes filecoin-project/sentinel#70