Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using block after nullrounds to find randomness #3619

Closed
wants to merge 2 commits into from

Conversation

nikkolasg
Copy link
Contributor

@nikkolasg nikkolasg commented Sep 7, 2020

Partially fix #3613

What's left to be done is to

  • Call e = MinDrandEntryEpoch() in the chain store
  • Look forward on the chain from this epoch e

Alternatively, to avoid looking forward (which seems to be complicated), it would be possible to start from the next epoch where drand is inserted, and look backwards until we reach e and we need to compare the beacon rounds to make sure we get the right one.

@magik6k magik6k added the impact/consensus Impact: Consensus label Sep 7, 2020
@arajasek arajasek closed this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/consensus Impact: Consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lotus fetches drand from chain backwards with null blocks while specs fetches forward
3 participants