fix: actor method params deserialization error exit code #3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
alanshaw
pushed a commit
to filecoin-project/test-vectors
that referenced
this pull request
Sep 11, 2020
…odes (#133) This adds additional assertions to ensure that the exit code for the receipt of an inner send is as expected. This also marks a couple of vectors as broken - their inner sends were not returning the correct exit code. The vectors marked as broken will be fixed in lotus by filecoin-project/lotus#3730 Please see #93 for the backstory!
alanshaw
force-pushed
the
fix/deserialization-err-code
branch
from
5224ee3
to
24c08a0
Compare
|
Superseded by #4783 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the exit code for deserializing params for an actor method to be
ErrSerialization(21)notSysErrSenderInvalid(1).Issue here for context: filecoin-project/test-vectors#93 (comment)
I have a PR open with interoperable test vectors I've verified will start passing when this change is made.