Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix conformance gen #3892

Merged
merged 1 commit into from
Sep 18, 2020
Merged

fix conformance gen #3892

merged 1 commit into from
Sep 18, 2020

Conversation

deaswang
Copy link
Contributor

when make gen . The cbor_gen.go generated in conformance folder, but it should be in chaos folder.

@raulk raulk requested a review from alanshaw September 17, 2020 23:32
raulk
raulk approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@raulk raulk merged commit 9afdda4 into filecoin-project:master Sep 18, 2020
@alanshaw
Copy link
Member

Awesome, thanks, I wanted to send a fix for this but didn't get round to it!

@deaswang deaswang deleted the fix-gen branch December 16, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulk raulk raulk approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deaswang @alanshaw @raulk