Add lotus shed util to validate a tipset #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
approved these changes
Sep 28, 2020
magik6k
reviewed
Sep 28, 2020
node/impl/full/sync.go
Outdated
Comment on lines
142
to
148
| err = a.Syncer.ChainStore().UnmarkBlockAsValidated(ctx, blk) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| } | ||
|
|
||
| err = a.Syncer.ValidateTipSet(ctx, fts) |
There was a problem hiding this comment.
I'd feel a bit better if instead of UnmarkBlockAsValidated we had some context value which we'd check in syncer.store.IsBlockValidated to disable the validation cache, especially given that this method has the read perm set
There was a problem hiding this comment.
Yeah, a 'force tipset revalidation' flow makes sense to me, rather than having it be a two step thing
arajasek
force-pushed
the
asr/sync-validate
branch
from
8862d9c
to
c45c8f3
Compare
magik6k
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.