Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nil pointer in StateSectorPreCommitInfo #4082

Merged
merged 3 commits into from
Nov 23, 2020
Merged

fix nil pointer in StateSectorPreCommitInfo #4082

merged 3 commits into from
Nov 23, 2020

Conversation

leviok
Copy link
Contributor

@leviok leviok commented Sep 29, 2020

No description provided.

@magik6k
Copy link
Contributor

magik6k commented Oct 22, 2020

A more correct fix would be to make this method return a pointer, and return nil/null when precommit was not found

@leviok
Copy link
Contributor Author

leviok commented Oct 23, 2020

You are right. This is a careless fix.

magik6k
magik6k reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on latest master to fix build?

@leviok
Copy link
Contributor Author

leviok commented Nov 23, 2020

@magik6k done

magik6k
magik6k reviewed Nov 23, 2020
View reviewed changes
node/impl/full/state.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit be2a594 into filecoin-project:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leviok @magik6k @Kubuxu