Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use bitswap sessions when fetching messages, and cancel them #4142

Merged
merged 1 commit into from
Oct 5, 2020
Merged

use bitswap sessions when fetching messages, and cancel them #4142

merged 1 commit into from
Oct 5, 2020

Commits on Oct 2, 2020

  1. use bitswap sessions when fetching messages, and cancel them 

    1. Explicitly use a session when fetching messages for a block. Technically,
GetBlocks would use an internal session so we'd only end up with two, but one
per block is even better.
2. Actually cancel sessions after a timeout (threading through the context).

NOTE: We should seriously consider having a single session for all blocks, but
we can do that in a followup as it may have unintended consequences (e.g., leaks).
    @Stebalien
    Stebalien committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    53cc1f1 View commit details
    Browse the repository at this point in the history