fix(sync): remove checks bypass when we submit the block #4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
magik6k
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
If I remember correctly we needed this for the early code to work correctly, I think it's ok to remove, though @whyrusleeping should confirm
Closed
|
I don't think devnets will work with this? not sure |
|
Nope, devnets work fine with this (including debug/fake proof mode) |
bibibong
pushed a commit
to EpiK-Protocol/go-epik
that referenced
this pull request
Jan 13, 2021
…tis/sync/remove-self-bypass fix(sync): remove checks bypass when we submit the block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to get the conversation started and run all the tests.
Background on the removed code: #17 (comment).