add an api for removing multisig signers #4274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Oct 9, 2020
magik6k
approved these changes
Oct 9, 2020
|
@Stebalien its fixing some really terrible UX. |
|
But it's a very late breaking change to a widely used (I assume?) API. I agree with the change in general, I just want to make sure you've thought about the fallout). We can always add an |
|
@Stebalien yep. Breaking the API on purpose. will be much harder the longer we wait. |
Stebalien
approved these changes
Oct 10, 2020
|
Fair enough. |
magik6k
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.