Miner Data Transfer Restart Cmd #4387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
requested review from
Kubuxu,
magik6k,
raulk and
whyrusleeping
as code owners
magik6k
reviewed
Oct 14, 2020
| @@ -102,6 +104,9 @@ type StorageMiner interface { | |||
| PiecesGetPieceInfo(ctx context.Context, pieceCid cid.Cid) (*piecestore.PieceInfo, error) | |||
| PiecesGetCIDInfo(ctx context.Context, payloadCid cid.Cid) (*piecestore.CIDInfo, error) | |||
|
|
|||
| // MinerRestartDataTransfer attempts to restart a data transfer with the given transfer ID and other peer | |||
| MinerRestartDataTransfer(ctx context.Context, transferID datatransfer.TransferID, otherPeer peer.ID, isInitiator bool) error | |||
There was a problem hiding this comment.
Should probably be prefixed with Markets and be next to MarketDataTransferUpdates
hannahhoward
requested changes
Oct 14, 2020
There was a problem hiding this comment.
- Naming change suggested by @magik6k
- Command should just be "restart"
- Initiator should default to false on miner side
I also noticed there's a change to test-vectors in this PR -- is that intentional? If not, remove
| } | ||
|
|
||
| var minerRestartTransfer = &cli.Command{ | ||
| Name: "restart-transfer", |
There was a problem hiding this comment.
this can just be "restart" rather than "restart-transfer" cause the miner command will already be under the "data-transfers" namespace
| &cli.BoolFlag{ | ||
| Name: "initiator", | ||
| Usage: "specify only transfers where peer is/is not initiator", | ||
| Value: true, |
There was a problem hiding this comment.
Initiator on this side should default to false 99% of the time the miner is NOT the initiator of the request (even when sending data)
|
@magik6k @hannahhoward Have made the changes. The test failure looks like a flaky. |
|
Done in #4572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4380.
@hannahhoward Where should I add the documentation for this command ?