Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix message list api #4422

Merged
merged 3 commits into from
Oct 16, 2020
Merged

fix message list api #4422

merged 3 commits into from
Oct 16, 2020

Conversation

whyrusleeping
Copy link
Member

No description provided.

@Kubuxu
Copy link
Contributor

Kubuxu commented Oct 15, 2020

Doc gen.

@Kubuxu
Copy link
Contributor

Kubuxu commented Oct 15, 2020

also a bit API breaking

@whyrusleeping
Copy link
Member Author

@Kubuxu it doesnt actually break the API

@Kubuxu
Copy link
Contributor

Kubuxu commented Oct 16, 2020

I guess not breaking because you shouldn't send full message to that API.

@magik6k magik6k merged commit 4a057d8 into master Oct 16, 2020
@magik6k magik6k deleted the fix/message-list branch October 16, 2020 18:52
@mostcute
Copy link

Hello, guys. I started a new node with a snapshot import, then i want to run list-messages api. it print some messages and then break with blockstore: block not found . I guess it is because sanpshot don't have all messages. so how to make a node which start with a snapshot to sync all message agian?

@mostcute
Copy link

@whyrusleeping @magik6k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

@magik6k magik6k magik6k approved these changes

@arajasek arajasek Awaiting requested review from arajasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whyrusleeping @Kubuxu @mostcute @magik6k