Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miner: fix init --create-worker-key #4475

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 19, 2020

Fixes #1536

Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +634 to +635
From: owner,
To: worker,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the worker is the owner this is a self transference then, will that be processed (the actor created) normally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When that happens, and we manage to get here, we'll likely fail as that would mean that the owner key doesn't exist on chain either

@magik6k magik6k merged commit 6bdf993 into master Oct 22, 2020
@magik6k magik6k deleted the fix/miner-init-createworker branch October 22, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

louts Use create-worker-key to create an error
2 participants