Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add termination-estimate to get an estimation for how much a termination penalty will be #4617

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

jennijuju
Copy link
Member

  • Usage example: ./lotus-shed sectors termation-estimate 5 8 10.

Resolves #4616

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great if you could add the "detect pending terminations" function @Stebalien discussed. It would probably need adding a new method to chain/actors/builtin/miner/miner.go, and its implementations.

If not, throw a TODO in the code and merge this, it's only going into shed.

@jennijuju
Copy link
Member Author

@Stebalien @arajasek thanks for the feedbacks! after talking to Steve, i think we can merge this one as it is as a very rough estimation, and then im gonna create another ticket to implement the more accurate option(sweep back the tipset until pending termination is 0) .

@arajasek
Copy link
Contributor

@jennijuju That's fine, but do add a TODO in the code summarising the discussion here.

…ation penalty will be:

- Usage example: `./lotus-shed sectors termation-estimate 5 8 10`.
@jennijuju
Copy link
Member Author

@jennijuju That's fine, but do add a TODO in the code summarising the discussion here.

added

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for first impl

@magik6k magik6k merged commit 3c9e438 into master Nov 6, 2020
@magik6k magik6k deleted the termination-penalty branch November 6, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a way to estimate termination penalty
4 participants