polish: add ClaimsChanged and DiffClaims method to power shim #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
approved these changes
Oct 28, 2020
Stebalien
approved these changes
Oct 28, 2020
frrist
commented
Oct 29, 2020
| } | ||
|
|
||
| func fromV2Claim(v2 power2.Claim) Claim { | ||
| return Claim{ |
There was a problem hiding this comment.
power2.Claim has an extra field (SealProofType) that Claim does not, I think ignoring it here should be fine but wanted to flag.
frrist
commented
Oct 29, 2020
| Claim Claim | ||
| } | ||
|
|
||
| func DiffClaims(pre, cur State) (*ClaimChanges, error) { |
There was a problem hiding this comment.
@Stebalien would you mind giving this a second look, I've added this since the initial request for review.
|
|
frrist
changed the title
magik6k
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by inspection performed in Visor.