add bench env print #5222
Merged
add bench env print #5222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deaswang
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
reviewed
Jan 5, 2021
cmd/lotus-bench/main.go
Outdated
Comment on lines
449
to
459
| fmt.Println("environment variable list:") | ||
| for _, envKey := range []string{"BELLMAN_NO_GPU", "FIL_PROOFS_MAXIMIZE_CACHING", "FIL_PROOFS_USE_GPU_COLUMN_BUILDER", | ||
| "FIL_PROOFS_USE_GPU_TREE_BUILDER", "FIL_PROOFS_USE_MULTICORE_SDR", "BELLMAN_CUSTOM_GPU"} { | ||
| envValue, found := os.LookupEnv(envKey) | ||
| if found { | ||
| fmt.Printf("%s=%s\n", envKey, envValue) | ||
| } else { | ||
| fmt.Printf("%s not set\n", envKey) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We shouldn't print this in json mode
There was a problem hiding this comment.
add envVar to BenchResults for json output.
magik6k
approved these changes
Jan 6, 2021
Kubuxu
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some environment variable print. Because they affect bench result.