add calibnet and mainnet in version #5387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deaswang
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
reviewed
Jan 20, 2021
build/params_2k.go
Outdated
| @@ -36,7 +36,7 @@ func init() { | |||
| policy.SetConsensusMinerMinPower(abi.NewStoragePower(2048)) | |||
| policy.SetMinVerifiedDealSize(abi.NewStoragePower(256)) | |||
|
|
|||
| BuildType |= Build2k | |||
| BuildType = Build2k | |||
There was a problem hiding this comment.
This was like that because in debug mode 2k params (this file) also execute, which may result in a wrong version in debug mode
magik6k
approved these changes
Jan 21, 2021
magik6k
reviewed
Jan 21, 2021
There was a problem hiding this comment.
Some tests (likely in api/test/test.go) broke - https://app.circleci.com/pipelines/github/filecoin-project/lotus/12499/workflows/f1afc69a-26df-475e-9c96-e8f1368fa3e5/jobs/108603/tests#failed-test-0
deaswang
force-pushed
the
build-network
branch
from
68628e0
to
d0a1c52
Compare
magik6k
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5373