Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stale imports in testplans/lotus-soup. #5425

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Conversation

raulk
Copy link
Member

@raulk raulk commented Jan 26, 2021

No description provided.

@nonsense
Copy link
Member

This LGTM, but I'd rather we merge #4995 because there are more things wrong with the way the test plans are included in the Lotus codebase at the moment.

@raulk
Copy link
Member Author

raulk commented Jan 26, 2021

Closing in favour of the more complete solution: #4995.

@raulk raulk closed this Jan 26, 2021
@raulk raulk deleted the fix/lotus-soup-deps branch January 26, 2021 13:10
@raulk raulk restored the fix/lotus-soup-deps branch January 29, 2021 21:12
@raulk
Copy link
Member Author

raulk commented Jan 29, 2021

Reopening to merge this smaller PR ahead of #4995, as these stale import paths are blocking further refactors.

@raulk raulk reopened this Jan 29, 2021
@raulk raulk mentioned this pull request Jan 29, 2021
5 tasks
@magik6k magik6k merged commit 7e692a5 into master Jan 29, 2021
@magik6k magik6k deleted the fix/lotus-soup-deps branch January 29, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants