Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to extend sector expiration #5666

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Feb 23, 2021

Resolves #5011

@magik6k
Copy link
Contributor Author

magik6k commented Feb 23, 2021

(tested manually on my miner)

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with an optional suggestion

Deadline: l.Deadline,
Partition: l.Partition,
Sectors: bitfield.NewFromSet(numbers),
NewExpiration: abi.ChainEpoch(cctx.Int64("new-expiration")),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to sanity-check this param (positive / greater than all the current expiration epochs / whatever actors code expects)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure that MpoolPush will fail with a nice error message when that happens

@magik6k magik6k changed the base branch from master to next March 8, 2021 16:57
@magik6k magik6k merged commit 8a5cd21 into next Mar 8, 2021
@magik6k magik6k deleted the feat/extend-sectors-cmd branch March 8, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a CMD/API to extend sector lifetime
2 participants