Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retry proof when randomness changes #5768

Merged
merged 1 commit into from
Mar 10, 2021
Merged

fix: retry proof when randomness changes #5768

merged 1 commit into from
Mar 10, 2021

Conversation

Stebalien
Copy link
Member

Simply warning isn't enough.

@Stebalien
fix: retry proof when randomness changes
84f721e 
Simply warning isn't enough.
magik6k
magik6k reviewed Mar 10, 2021
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still would retry, ~15 lines below

@Stebalien
Copy link
Member Author

Ah, because we check with checkRand? I see. But that's really confusing and brittle. Can we just be explicit?

@magik6k magik6k merged commit c0d1f44 into master Mar 10, 2021
@magik6k magik6k deleted the fix/retry-proof-on-rand-change branch March 10, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @magik6k