Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupds: Allow larger values in write log #5776

Merged
merged 2 commits into from
Mar 11, 2021
Merged

backupds: Allow larger values in write log #5776

merged 2 commits into from
Mar 11, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 11, 2021

Datastore entries can be larger than a few kb, which would lead us to create corrupted logs

Kubuxu
Kubuxu approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to collect a set of use-cases and requirements for cbor-gen and make it work for them

@magik6k magik6k merged commit 189dc47 into master Mar 11, 2021
@magik6k magik6k deleted the fix/backupds-len-checks branch March 11, 2021 14:17
@arajasek arajasek mentioned this pull request Mar 17, 2021
Closed
38 tasks
@arajasek arajasek mentioned this pull request Mar 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magik6k @Kubuxu