add lotus client cancel-retrieval cmd to lotus CLI

[nonsense]

Fixes #5870

---

Added by @raulk:

This command might seem redudant with lotus client cancel-transfer. However:

1. This cancels the retrieval deal no matter which stage it's at (transfer or not).
2. Retrieval currently has some edge cases where cancelling the transfer will not cancel the retrieval deal.
3. We should probably get rid of lotus client cancel-transfer, and instead rely on the commands to cancel the deals themselves, which would terminate the deal regardless of the stage.

[nonsense]

1. test and test-short seem flaky and I think failures are not related.

2. After running make docsgen, I get three files that are modified:

	modified:   build/openrpc/full.json.gz
	modified:   build/openrpc/miner.json.gz
	modified:   build/openrpc/worker.json.gz

Not sure if I should be replacing these as part of the PR?

[magik6k]

2 comments

(needs make gen)

[aarshkshah1992]

@magik6k @dirkmc Have addressed the review comments.

But, on running make gen, I seem to be running into some weird import error:

# github.com/filecoin-project/lotus/api/apistruct
api/apistruct/struct.go:6:1: imported and not used: "bytes"
api/apistruct/struct.go:8:1: imported and not used: "encoding/json"
api/apistruct/struct.go:9:1: imported and not used: "fmt"
api/apistruct/struct.go:19:1: imported and not used: "github.com/filecoin-project/go-state-types/big"
api/apistruct/struct.go:23:1: imported and not used: "github.com/filecoin-project/lotus/chain/actors/builtin"
api/apistruct/struct.go:27:1: imported and not used: "github.com/filecoin-project/lotus/chain/actors/builtin/power"
api/apistruct/struct.go:35:1: market redeclared as imported package name
	previous declaration at api/apistruct/struct.go:24:1
api/apistruct/struct.go:35:1: imported and not used: "github.com/filecoin-project/specs-actors/v2/actors/builtin/market"
api/apistruct/struct.go:43:1: imported and not used: "github.com/libp2p/go-libp2p-pubsub" as pubsub
api/apistruct/struct.go:44:1: imported and not used: "github.com/multiformats/go-multiaddr" as multiaddr
api/apistruct/struct.go:44:1: too many errors
make: *** [type-gen] Error 2

What should I do to fix this ?

[dirkmc]

I was able to successfully run make gen and pushed the changes

[dirkmc]

It wasn't possible to add the command as a subcommand of lotus client retrieve because lotus client retrieve is itself a command that takes arguments.
Instead I've named it lotus client retrieve-cancel

[raulk]

This has been squashed into https://github.com/filecoin-project/lotus/tree/minerx/staging for minerX early testing.

[arajasek]

Fixes #5870

[magik6k]

An integration test would be great to have

[nonsense]

An integration test would be great to have

Note that this is not forgotten, I just got pulled into something else. I think when we add list retrieval deals command, it should be trivial to add an integration test for this cmd as well.