-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paginate and filter storage client deals list #5886
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
March 26, 2021 11:46
2 tasks
All possible options with which we can filter
All Deals
Just show the first two deals
Show deals after a certain time offset
Show the first two deals after a certain time offset
|
dirkmc
reviewed
Mar 26, 2021
dirkmc
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
magik6k
added
the
team/ignite
Issues and PRs being tracked by Team Ignite at Protocol Labs
label
Jun 3, 2021
raulk
removed
the
team/ignite
Issues and PRs being tracked by Team Ignite at Protocol Labs
label
Jun 8, 2021
Built in markets are now deprecated in lotus, this feature won't land |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4185 .
TODO