drand: fix beacon cache #6164
Merged
drand: fix beacon cache #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
approved these changes
Apr 30, 2021
Kubuxu
approved these changes
Apr 30, 2021
Kubuxu
reviewed
Apr 30, 2021
| @@ -168,8 +168,8 @@ func (db *DrandBeacon) getCachedValue(round uint64) *types.BeaconEntry { | |||
| if !ok { | |||
| return nil | |||
| } | |||
| e, _ := v.(*types.BeaconEntry) | |||
| return e | |||
| e, _ := v.(types.BeaconEntry) | |||
There was a problem hiding this comment.
Maybe switch to storying pointers in the cache. Now we are pulling out a pointer (interface{}) out of the cache, dereferencing it to struct, and then we take a pointer of that struct which escapes causing allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.