Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIP 13 addenda: correctly handle commit batch timer #6282

Merged
merged 4 commits into from
May 18, 2021
Merged

FIP 13 addenda: correctly handle commit batch timer #6282

merged 4 commits into from
May 18, 2021

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented May 18, 2021

No description provided.

@vyzo vyzo requested a review from magik6k May 18, 2021 11:32
magik6k
magik6k reviewed May 18, 2021
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good, just 1 note

The config values also need to be wired through in node/modules/storageminer.go ~L820~850

extern/storage-sealing/commit_batch.go Outdated Show resolved Hide resolved
extern/storage-sealing/commit_batch.go Outdated Show resolved Hide resolved
magik6k
magik6k reviewed May 18, 2021
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing

extern/storage-sealing/commit_batch.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit 5614520 into feat/fip-0013 May 18, 2021
@magik6k magik6k deleted the feat/fip-0013-addenda branch May 18, 2021 14:23
@BigLep BigLep added this to the Network Hyperdrive milestone May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Network Hyperdrive
Development

Successfully merging this pull request may close these issues.
3 participants
@vyzo @magik6k @BigLep