events: Fix handling of multiple matched events per epoch #6355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
approved these changes
May 30, 2021
|
Great stuff! This was happening on occasion on Testground as well, awesome that it is fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a reliable repro for the deals getting stuck in StorageDealAwaitingPreCommit issue when trying to debug #6041 with rr (which runs with one thread, and makes everything slower).
Basically, we would ignore (Pre)Commit messages if there was more than one matching message from a miner in a given epoch. Normally we wouldn't hit this very often, but it was pretty common case of test flakiness.
Fixes #6123
Fixes #5890
Fixes #5377
Fixes #2249 (probably)