Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor verifreg test to kit2 #6469

Merged
merged 4 commits into from
Jun 16, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Jun 14, 2021

TODO: currently the test fails with

    verifreg_test.go:64: AddVerifier failed:  getting key address: failed to get account actor state for f080: unknown actor code bafkqadtgnfwc6mrpnv2wy5djonuwo

when calling the AddVerifier method

@dirkmc dirkmc changed the base branch from master to raulk/itests-refactor-kit June 14, 2021 14:21
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's migrate to require 🙏

Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed what was happening here. The issue is that when I implemented kit2, I set up the default verifier root key in the genesis, which is a multisig of 1 with a hardcoded address. Therefore, the test had no permissions to add a verifier!

I fixed this by adding a new ensemble option that enables us to specify the root verifier key at genesis, also assigning it some balance (so it can actually send messages to add verifiers). The option is called RootVerifier.

I also took the opportunity to add an Account functional option with which one can set up arbitrary accounts with arbitrary balances in genesis.

We use this to set up the verifier account.

@dirkmc -- there was some other test that was sending balance from a miner to a new account. That test can be migrated to the Account() option 🙏

@raulk raulk marked this pull request as ready for review June 16, 2021 18:46
@raulk raulk merged commit 2c30ac3 into raulk/itests-refactor-kit Jun 16, 2021
@raulk raulk deleted the refactor/itest-verifreg branch June 16, 2021 18:46
Height: 4,
Migration: stmgr.UpgradeActorsV5,
}}
fullSchedule := stmgr.UpgradeSchedule{}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be

fullSchedule := DefaultTestUpgradeSchedule

Otherwise I think the for loop is a noop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants