-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor verifreg test to kit2 #6469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's migrate to require 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed what was happening here. The issue is that when I implemented kit2, I set up the default verifier root key in the genesis, which is a multisig of 1 with a hardcoded address. Therefore, the test had no permissions to add a verifier!
I fixed this by adding a new ensemble option that enables us to specify the root verifier key at genesis, also assigning it some balance (so it can actually send messages to add verifiers). The option is called RootVerifier
.
I also took the opportunity to add an Account
functional option with which one can set up arbitrary accounts with arbitrary balances in genesis.
We use this to set up the verifier account.
@dirkmc -- there was some other test that was sending balance from a miner to a new account. That test can be migrated to the Account()
option 🙏
Height: 4, | ||
Migration: stmgr.UpgradeActorsV5, | ||
}} | ||
fullSchedule := stmgr.UpgradeSchedule{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
fullSchedule := DefaultTestUpgradeSchedule
Otherwise I think the for
loop is a noop
TODO: currently the test fails with
when calling the AddVerifier method