Miner SimultaneousTransfers config #6612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
approved these changes
Jun 28, 2021
|
Suggestion: capture all transfer start/stop events (by subscribing to markets events), set a limit of –say– 2 simultaneous transfers, perform 100 concurrent transfers, and then go over the events to ensure that only 2 transfers were ever active at a time. |
magik6k
force-pushed
the
feat/miner-par-transfers-cfg
branch
from
69e4545
to
e9dd3e8
Compare
magik6k
commented
Jun 28, 2021
| }() | ||
|
|
||
| dh.RunConcurrentDeals(kit.RunConcurrentDealsOpts{ | ||
| N: 1, // TODO: set to 20 after https://github.com/ipfs/go-graphsync/issues/175 is fixed |
There was a problem hiding this comment.
With this set to 10, when the test would not hang because of this issue, the assert below would fail if the config wasn't set, and it does pass when it's set
arajasek
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.