Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envvar to disable slash filter #6620

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Envvar to disable slash filter #6620

merged 3 commits into from
Jul 9, 2021

Conversation

arajasek
Copy link
Contributor

Maybe we merge this? Maybe we don't.

magik6k
magik6k reviewed Jun 29, 2021
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make the env var a bit more explicit in what can happen when this is set

miner/miner.go Outdated Show resolved Hide resolved
@arajasek @magik6k
Update miner/miner.go
3091e2a 
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
ribasushi
ribasushi approved these changes Jul 3, 2021
View reviewed changes
Copy link
Collaborator

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Suggested varname change

Can be merged as-is though

miner/miner.go Outdated Show resolved Hide resolved
@arajasek @ribasushi
Update miner/miner.go
dff097a 
Co-authored-by: Peter Rabbitson <ribasushi@protocol.ai>
@arajasek arajasek enabled auto-merge July 9, 2021 21:08
@arajasek arajasek merged commit f7f5fd4 into master Jul 9, 2021
@arajasek arajasek deleted the asr/no-filter branch July 9, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k left review comments

@ribasushi ribasushi ribasushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arajasek @ribasushi @magik6k