Config for deal publishing control addresses #6697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
reviewed
Jul 7, 2021
magik6k
force-pushed
the
feat/dealpublish-ctl-config
branch
from
3069313
to
9bdea91
Compare
arajasek
approved these changes
Jul 8, 2021
| @@ -132,6 +132,17 @@ func GetMaxProveCommitDuration(ver actors.Version, t abi.RegisteredSealProof) ab | |||
| } | |||
| } | |||
|
|
|||
| func SetProviderCollateralSupplyTarget(num, denom big.Int) { | |||
There was a problem hiding this comment.
Can we throw label on here
// SetProviderCollateralSupplyTarget sets the percentage of normalized circulating
// supply that must be covered by provider collateral in a deal. This should
// only be used for testing.
| @@ -132,6 +132,17 @@ func GetMaxProveCommitDuration(ver actors.Version, t abi.RegisteredSealProof) ab | |||
| } | |||
| } | |||
|
|
|||
| func SetProviderCollateralSupplyTarget(num, denom big.Int) { | |||
| {{range .versions}} | |||
| {{if (ge . 2)}} | |||
There was a problem hiding this comment.
Guessing we're not doing this for earlier versions just because it isn't that helpful and the ProvCollateralPercentSupplyNumV0 / ProvCollateralPercentSupplyNumV1 thing is messy?
There was a problem hiding this comment.
We didn't have supply target in v0 actors
There was a problem hiding this comment.
(and v1 actors didn't exist)
There was a problem hiding this comment.
isn't that what ProvCollateralPercentSupplyNumV0 and ProvCollateralPercentSupplyNumV1 did in v0 actors?
There was a problem hiding this comment.
Oh, maybe, but somehow those don't seem to matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be useful when running with a separate market miner node - will let miners run a separate lotus daemon without the worker key
Also fixes #6676