Unsubscribe slow chain head subscribers #6974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
The reader can just re-subscribe when they're ready to catch up. This prevents a slow reader from bogging down the entire system.
|
Ok, so it looks like this is revealing a bug in the events system as it doesn't correctly play "catchup". |
|
My diagnosis is correct, but fixing this is going to be slightly painful. |
|
Closing in favor of #7000. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, slow readers can just "resubscribe" when they're able to catch up. That way, a single slow leader doesn't block all notifications.
fixes #6883, #6947