Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch deal slashed because sector was terminated #7201

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Aug 27, 2021

When a sector is terminated, the deal state will be updated with a slash epoch.

This PR fixes a bug where OnDealExpiredOrSlashed would not notice that change.

@dirkmc dirkmc requested a review from a team as a code owner August 27, 2021 10:29
@dirkmc dirkmc requested a review from raulk August 27, 2021 10:30
@dirkmc dirkmc force-pushed the fix/on-deal-expired branch 3 times, most recently from 276232a to e46e983 Compare August 27, 2021 10:44
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #7201 (07dcb07) into master (c19ee58) will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7201      +/-   ##
==========================================
+ Coverage   39.13%   39.17%   +0.04%     
==========================================
  Files         608      608              
  Lines       64555    64555              
==========================================
+ Hits        25263    25292      +29     
+ Misses      34915    34878      -37     
- Partials     4377     4385       +8     
Impacted Files Coverage Δ
markets/storageadapter/ondealexpired.go 52.83% <50.00%> (+9.43%) ⬆️
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
storage/addresses.go 55.95% <0.00%> (-8.34%) ⬇️
chain/actors/builtin/paych/paych.go 16.88% <0.00%> (-5.20%) ⬇️
chain/stmgr/call.go 66.00% <0.00%> (-4.00%) ⬇️
node/hello/hello.go 63.21% <0.00%> (-3.45%) ⬇️
itests/kit/blockminer.go 93.65% <0.00%> (-1.59%) ⬇️
chain/vm/vm.go 59.47% <0.00%> (-1.12%) ⬇️
paychmgr/simple.go 79.93% <0.00%> (-0.93%) ⬇️
chain/store/store.go 63.76% <0.00%> (-0.72%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c19ee58...07dcb07. Read the comment docs.

@raulk raulk merged commit 982a377 into master Aug 27, 2021
@raulk raulk deleted the fix/on-deal-expired branch August 27, 2021 11:45
magik6k added a commit that referenced this pull request Aug 30, 2021
…nges

revert changes to OnDealExpiredOrChanged in #5431 #7201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants