sectors expired: Handle precomitted and unproven sectors correctly #7236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7236 +/- ##
==========================================
- Coverage 39.10% 39.07% -0.04%
==========================================
Files 610 610
Lines 64716 64730 +14
==========================================
- Hits 25305 25291 -14
- Misses 35021 35045 +24
- Partials 4390 4394 +4
Continue to review full report at Codecov.
|
ZenGround0
approved these changes
Aug 31, 2021
| @@ -549,6 +549,10 @@ func (p *partition{{.v}}) RecoveringSectors() (bitfield.BitField, error) { | |||
| return p.Partition.Recoveries, nil | |||
| } | |||
|
|
|||
| func (p *partition{{.v}}) UnprovenSectors() (bitfield.BitField, error) { | |||
| return {{if (ge .v 2)}}p.Partition.Unproven{{else}}bitfield.New(){{end}}, nil | |||
There was a problem hiding this comment.
The fact that you can specify if (ge .v 2) highlights how nice this autogen template format is 👌
| @@ -1628,12 +1628,31 @@ var sectorsExpiredCmd = &cli.Command{ | |||
| } | |||
|
|
|||
| toCheck, err = bitfield.SubtractBitField(toCheck, live) | |||
There was a problem hiding this comment.
super nit: if we change the generic name toCheck to something more descriptive i.e. deadSectors it will make this slightly more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this we'd say that sectors which were not PoSt-ed yet were already expired.