Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sealing: Fix retry loop in SubmitCommitAggregate #7245

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 1, 2021

Without this if something about the sector would be broken in a way which caused m.commiter.AddCommit to instantly error (e.g. sector expired), we'd blindly retry with no delay, causing tons of log spam and fsm io.

Fixes #7057

@magik6k magik6k requested a review from a team as a code owner September 1, 2021 09:36
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #7245 (41db98d) into master (6a02237) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7245      +/-   ##
==========================================
+ Coverage   39.09%   39.11%   +0.02%     
==========================================
  Files         610      610              
  Lines       64753    64751       -2     
==========================================
+ Hits        25315    25329      +14     
+ Misses      35043    35023      -20     
- Partials     4395     4399       +4     
Impacted Files Coverage Δ
extern/storage-sealing/fsm.go 57.42% <ø> (+0.80%) ⬆️
extern/storage-sealing/states_sealing.go 38.04% <0.00%> (+0.16%) ⬆️
chain/actors/builtin/paych/paych.go 16.88% <0.00%> (-5.20%) ⬇️
extern/sector-storage/worker_tracked.go 90.14% <0.00%> (-4.23%) ⬇️
storage/wdpost_sched.go 75.24% <0.00%> (-3.97%) ⬇️
chain/stmgr/searchwait.go 62.09% <0.00%> (-2.62%) ⬇️
itests/kit/blockminer.go 93.65% <0.00%> (-1.59%) ⬇️
chain/stmgr/execute.go 74.09% <0.00%> (-1.04%) ⬇️
paychmgr/simple.go 79.93% <0.00%> (-0.93%) ⬇️
storage/wdpost_run.go 69.62% <0.00%> (-0.64%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a02237...41db98d. Read the comment docs.

Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magik6k magik6k merged commit 5831a6b into master Sep 2, 2021
@magik6k magik6k deleted the fix/commagg-loop branch September 2, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SubmitCommitAggregate fail in loop
2 participants