Add partition info to the 'sectors status' command #7246
Conversation
magik6k
force-pushed
the
feat/sectorinfo-partition
branch
from
6812a61
to
dbdaa32
Compare
Codecov Report
@@ Coverage Diff @@
## master #7246 +/- ##
==========================================
- Coverage 39.09% 39.08% -0.01%
==========================================
Files 610 610
Lines 64753 64809 +56
==========================================
+ Hits 25315 25333 +18
- Misses 35043 35085 +42
+ Partials 4395 4391 -4
Continue to review full report at Codecov.
|
| Aliases: []string{"p"}, | ||
| }, | ||
| &cli.BoolFlag{ | ||
| Name: "proof", |
There was a problem hiding this comment.
For my info is this proof of replication (was thinking it could also be latest post proof)? Couldn't find the answer easily from looking at api types because api.SectorInfo is only populated with disk reads.
There was a problem hiding this comment.
Since I'm probably not alone in not knowing the usage field would benefit from explaining this: "print proof of replication for sector", or "print latest proof of spacetime for sector"
| } | ||
|
|
||
| errFound := errors.New("found") | ||
| if err := mas.ForEachDeadline(func(dlIdx uint64, dl miner.Deadline) error { |
There was a problem hiding this comment.
Future Improvement: what is the current thinking around the lotus miner creating a persistent index from sector id to partition? It seems like this linear traversal is fairly common and potentially expensive. I'm sure big miners have this already but it would be nice to have out of the box with lotus. If we ask around maybe a mining operation would donate their code too.
magik6k
force-pushed
the
feat/sectorinfo-partition
branch
from
dbdaa32
to
39892d4
Compare
magik6k
force-pushed
the
feat/sectorinfo-partition
branch
from
39892d4
to
fea430a
Compare
No description provided.