Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug for CommittedCapacitySectorLifetime #7337

Merged

Conversation

ldoublewood
Copy link
Contributor

This PR is fixing the follow two bugs related to #7333

  • Wrong default CommittedCapacitySectorLifetime config value
  • CommittedCapacitySectorLifetime config item is not working

@ldoublewood ldoublewood requested a review from a team as a code owner September 16, 2021 01:37
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

Needs make gen

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #7337 (eb2bbfe) into release/v1.11.3 (e786a05) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.11.3    #7337      +/-   ##
===================================================
- Coverage            39.17%   39.14%   -0.03%     
===================================================
  Files                  614      614              
  Lines                64983    64985       +2     
===================================================
- Hits                 25456    25439      -17     
- Misses               35125    35143      +18     
- Partials              4402     4403       +1     
Impacted Files Coverage Δ
node/config/def.go 98.63% <100.00%> (ø)
node/modules/storageminer.go 62.37% <100.00%> (+0.12%) ⬆️
extern/sector-storage/sched_resources.go 75.00% <0.00%> (-9.38%) ⬇️
chain/actors/builtin/paych/paych.go 16.88% <0.00%> (-5.20%) ⬇️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
storage/wdpost_sched.go 77.22% <0.00%> (-3.97%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-3.64%) ⬇️
itests/kit/blockminer.go 93.65% <0.00%> (-1.59%) ⬇️
chain/vm/vm.go 59.47% <0.00%> (-1.12%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-0.48%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e786a05...eb2bbfe. Read the comment docs.

@magik6k magik6k merged commit 3c65595 into filecoin-project:release/v1.11.3 Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants