Chore/dm level tests plus merkle proof cars #7673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am open to having a flag or something, as long as the behavior reflected in deals_partial_retrieval_dm-level_test.go can be preserved for v0, and opt-in for v1
ribasushi
force-pushed
the
chore/DM-level-tests_plus_merkle-proof-cars
branch
from
6ea7ca4
to
407bf49
Compare
magik6k
approved these changes
Nov 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #7673 +/- ##
==========================================
+ Coverage 39.45% 39.53% +0.07%
==========================================
Files 637 637
Lines 67928 67934 +6
==========================================
+ Hits 26803 26855 +52
+ Misses 36510 36460 -50
- Partials 4615 4619 +4
Continue to review full report at Codecov.
|
ribasushi
added a commit
that referenced
this pull request
Nov 25, 2021
- Adjust the ExportRef comment to reflect change from #7673 - Simplify control flow in parseDagSpec() ( read diff under -w )
ribasushi
added a commit
that referenced
this pull request
Nov 25, 2021
- Adjust the ExportRef comment to reflect change from #7673 - Simplify control flow in parseDagSpec() ( read diff under -w )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@magik6k moar fixture and the revert of the car-export change. Open to other ideas as per second commit msg.